Gnutella Forums

Gnutella Forums (https://www.gnutellaforums.com/)
-   Feature Requests & Bug Reports (https://www.gnutellaforums.com/feature-requests-bug-reports/)
-   -   Missing config options (https://www.gnutellaforums.com/feature-requests-bug-reports/68251-missing-config-options.html)

Dorsai65 March 19th, 2007 11:52 PM

Missing config options
 
Now that I've been using Phex for a while, here are a couple of things that I really wish could be configured:

a) ability to turn on/off chat; and
b) ability to permanently remove the default filters.

These are a couple of minor annoyances:
1) multiple IDENTICAL results listed, versus (some number) FILENAME; and
2) Phex doesn't remember window positions/sizes after I set them.

If I had the source code, I'd have a try at writing some patches...

:laugh_2:

GregorK March 20th, 2007 12:48 AM

You are very welcome to write some patches!

The most current SVN source code download instructions are here:
http://www.phex.org/wiki/index.php/Subversion
http://www.phex.org/wiki/index.php/B...rom_Subversion
http://sourceforge.net/svn/?group_id=27021

Old source of 3.0.2 code can be found here:
http://downloads.sourceforge.net/phe....2.100_src.zip

Dorsai65 March 20th, 2007 10:22 AM

I've had a look at the old source (3.0.2), and see where the default filter situation is: they are hard-coded into (phex/rules/DefaultSearchFilterRules.java)

Since not everyone will want to use these exact rules all the time, it might be better to remove this section in favor of putting them in a searchfilters.xml that is installed by default.

Similarly, chat is enabled by default, but there is no configuration option to change or save it.

I will poke around in the 3.0.2 code and see if I can find a solution to the chat and window position settings 'situations'. If I can, would it be acceptable for me to post the changes here? I've only done a little bit of Java programming, and never used Subversion, so I'm hesitant to risk messing things up for anyone else :-/

GregorK March 20th, 2007 11:20 AM

You can either submit your changes in the patches section of the sourceforge project page:
http://sourceforge.net/tracker/?grou...21&atid=388894

Or get your own private branch in Subversion. This is usually the way we work most of the time anyway. In your branch you can mess around without breaking anything, it can always be restored if needed and you don't get disturbed by other developments.
Once your changes are finished and tested they can be very easily merged into the main trunk for release.

You are welcome to contribute the way you prefer. If you need any specific help just ask here or on IRC #phex on freenode


All times are GMT -7. The time now is 09:38 AM.

Powered by vBulletin® Version 3.8.7
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
SEO by vBSEO 3.6.0 ©2011, Crawlability, Inc.

Copyright © 2020 Gnutella Forums.
All Rights Reserved.