Gnutella Forums  

Go Back   Gnutella Forums > Discontinued Gnutella Client Forums > Mutella (Linux/Unix)
Register FAQ The Twelve Commandments Members List Calendar Arcade Find the Best VPN Today's Posts

Mutella (Linux/Unix) Mutella has been discontinued. We highly recommend you use an actively developed client instead.


 
 
LinkBack Thread Tools Display Modes
Prev Previous Post   Next Post Next
  #2 (permalink)  
Old February 24th, 2002
Mutella Developer
 
Join Date: January 30th, 2002
Location: Germany
Posts: 87
maksik is flying high
Default

General answer: I haven't chosen those tactics, I've inherited it from Gnucleus with other bits of crap here and there and trying to clean up the code without breaking everything since day 1. So, IMHO the question should be addressed to the developers of Gnucleus

but, ok step by step:
a) MGnuSocket is a bit special type of socket, it's an incomming connection with yet undefined type. That is the other side did not initiated handshake yet. There is certain timeout while it makes sence to wait for a handshake, and when it's over the socket has to go. At the moment the implementation is ugly but it improves (v0.4 is somewhere on the way)

b) Historical reason. probably have to review it.

c,d) In principle it seems to make sence to remove all sockets only here, that is in
OnTimer()

Quote:
void MGnuSock::OnReceive()
DWORD dwBuffLength = Receive(m_pBuff, 32768);
see the begining of the message. Btw, it's gone in the current version (will be on CVS probably on Thursday)

Quote:
- Server socket class destructor should clean up also m_SockList?
this is right, but the current implementation only will produce memory leaks on application exit, which is not that important

Quote:
- All socket classes destructors should do this: if (m_hSocket != INVALID_SOCKET) Close();
something like that is already done in the MAsyncSocket's destructor

Quote:
- Closing sockets should be more friendly, a ForceDisconnect should only used if necesarry.
In general -- agree. Say "Shutdown" and than after few seconds "Close".

Thanks for the comments,
Guess on day I'll have time to complete and clean up all this mess...

--Max
Reply With Quote
 


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On


Similar Threads
Thread Thread Starter Forum Replies Last Post
any updates to mutella? Gateway Mutella (Linux/Unix) 3 December 2nd, 2005 05:13 PM
Mutella 0.4 is out! maksik Mutella (Linux/Unix) 5 November 20th, 2003 10:34 AM
mutella newbie question hotcarl Mutella (Linux/Unix) 2 September 8th, 2002 05:02 AM
Welcome to the Mutella forum maksik Mutella (Linux/Unix) 3 March 7th, 2002 07:36 AM
Why not a Mutella forum fefu Mutella (Linux/Unix) 7 March 7th, 2002 07:19 AM


All times are GMT -7. The time now is 05:10 AM.


Powered by vBulletin® Version 3.8.7
Copyright ©2000 - 2025, vBulletin Solutions, Inc.
SEO by vBSEO 3.6.0 ©2011, Crawlability, Inc.

Copyright © 2020 Gnutella Forums.
All Rights Reserved.